Skip to content

test(backup): Add final model tests #52924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

azaslavsky
Copy link
Contributor

This change adds all of the remaining model tests, save those added in PR #52778.

Issue: getsentry/team-ospo#156

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #52924 (eefb398) into master (f243492) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #52924   +/-   ##
=======================================
  Coverage   79.46%   79.46%           
=======================================
  Files        4936     4936           
  Lines      207432   207432           
  Branches    35425    35425           
=======================================
+ Hits       164833   164836    +3     
+ Misses      37560    37559    -1     
+ Partials     5039     5037    -2     

see 5 files with indirect coverage changes

Copy link
Contributor

@kneeyo1 kneeyo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from azaslavsky/backup/more_model_tests to master July 17, 2023 20:39
@azaslavsky azaslavsky enabled auto-merge (squash) July 17, 2023 21:32
This change adds all of the remaining model tests, save those added in
PR #52778.

Issue: getsentry/team-ospo#156
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/final_model_tests branch from a01e8d8 to eefb398 Compare July 17, 2023 21:33
@azaslavsky azaslavsky merged commit ecc36c6 into master Jul 17, 2023
@azaslavsky azaslavsky deleted the azaslavsky/backup/final_model_tests branch July 17, 2023 22:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants