ref(projects): Redirect post project transfer to project teams page #52925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ceorourke
commented
Jul 14, 2023
| this.props.router.push(normalizeUrl(`/organizations/${orgSlug}/projects/`)); | ||
| const projectSlug = this.state.transferDetails.project.slug; | ||
| this.props.router.push( | ||
| normalizeUrl(`/settings/${orgSlug}/projects/${projectSlug}/teams/`) |
There was a problem hiding this comment.
This was tough to test locally since we can't create new organizations - I went directly to the accept-transfer endpoint to accept the transfer, but it's not actually doing anything since it's "transferring" a project to the org it already belongs in.
Testing this in prod I was surprised to see that after accepting the project transfer, I'm not redirected to the project's new organization, which is what I'd expect to happen based on the existing code.
scttcper
approved these changes
Jul 17, 2023
ceorourke
added a commit
that referenced
this pull request
Jul 25, 2023
Take 2 of #52925 When a user approves transferring a project to a new organization the project isn't added to a team which results in confusion because the project doesn't show up on the projects page. The user needs to add the project to a team for it to show up in most places in the UI, so we should redirect them to the appropriate page to do so.
chloeho7
pushed a commit
that referenced
this pull request
Jul 25, 2023
Take 2 of #52925 When a user approves transferring a project to a new organization the project isn't added to a team which results in confusion because the project doesn't show up on the projects page. The user needs to add the project to a team for it to show up in most places in the UI, so we should redirect them to the appropriate page to do so.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user approves transferring a project to a new organization the project isn't added to a team which results in confusion because the project doesn't show up on the projects page. The user needs to add the project to a team for it to show up in most places in the UI, so we should redirect them to the appropriate page to do so.