ref(tsc): usageChart utils to tsx #52935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
cathteng
reviewed
Jul 17, 2023
| @@ -13,7 +13,7 @@ describe('getDateFromMoment', () => { | |||
| // Ensure date remains in UTC | |||
| it('shows the date if interval is >= 24h', () => { | |||
| expect(getDateFromMoment(start)).toBe('Jul 9'); | |||
| expect(getDateFromMoment(start, '7d')).toBe('Jul 9'); | |||
| expect(getDateFromMoment(start, '2d')).toBe('Jul 9'); | |||
There was a problem hiding this comment.
Suggested change
| expect(getDateFromMoment(start, '2d')).toBe('Jul 9'); | |
| expect(getDateFromMoment(start, '7d')).toBe('Jul 9'); |
this should be kept the same, right?
There was a problem hiding this comment.
I changed it since 7d is not a valid IntervalPeriod.
There was a problem hiding this comment.
do you mean 2d is not valid? It's 7d after your change
There was a problem hiding this comment.
That is Cathy's suggested change. I changed it from 7d to 2d.
There was a problem hiding this comment.
oh i see there's an IntervalPeriod object
cathteng
approved these changes
Jul 17, 2023
| @@ -13,7 +13,7 @@ describe('getDateFromMoment', () => { | |||
| // Ensure date remains in UTC | |||
| it('shows the date if interval is >= 24h', () => { | |||
| expect(getDateFromMoment(start)).toBe('Jul 9'); | |||
| expect(getDateFromMoment(start, '7d')).toBe('Jul 9'); | |||
| expect(getDateFromMoment(start, '2d')).toBe('Jul 9'); | |||
There was a problem hiding this comment.
oh i see there's an IntervalPeriod object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert utils.spec.jsx to tsx