ref(hc): Adding helpers for managing transactions #52943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
corps
commented
Jul 15, 2023
corps
commented
- Adds helper such that during a transaction, no executes occur on a differing connection
- Adds helper to collect transaction spans queries run on them, making it possible to write a test assertion about the transactional spans of methods.
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52943 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 4936 4936
Lines 207433 207481 +48
Branches 35426 35433 +7
=======================================
+ Hits 164832 164881 +49
Misses 37562 37562
+ Partials 5039 5038 -1
|
markstory
reviewed
Jul 17, 2023
| with transaction.atomic(using=router.db_for_write(Organization)): | ||
| Factories.create_organization() | ||
|
|
||
| with django_test_transaction_water_mark(): |
There was a problem hiding this comment.
Is the idea that we'll use django_test_transaction_water_mark() to escape the concurrent transaction detection?
There was a problem hiding this comment.
django_test_transaction_water_mark is used to mark a place when normally, a separate process would be occurring, and thus there would be no other baseline transactions. In a way, it escapes things like transaction.on_commit and the enforce_no_transaction and now the mixed transaction detection so that they don't get mixed up with these outer transactions that would not exist in production.
Examples include:
- celery jobs being run synchronously (outboxes)
- initial transactions wrapping tests
- rpc that would be hitting a separate endpoint.
| self.alias in open_transactions | ||
| ), f"Transaction opened for db {open_transactions}, but command running against db {self.alias}" | ||
|
|
||
| return execute(*params) |
There was a problem hiding this comment.
Is there anything we could wrap this in that would need **kwargs as well?
GabeVillalobos
approved these changes
Jul 18, 2023
This was referenced Jul 18, 2023
GabeVillalobos
added a commit
that referenced
this pull request
Jul 19, 2023
…using unguarded_write decorators (#53160) With the inclusion of our recent changes to transaction validations in PR #52943 and the inclusion of 'using' in all of our transactions/helpers thanks to PRs #53027 and #53004, we should be able to safely remove the ability to specify a transaction without a using keyword arg. Because this is now mandatory, it should also be safe to remove autorouting, which ended up being incorrect in many testing contexts anyway. This is a resubmission of PR #53080 which was reverted due to broken load-mocks and a single broken getsentry migration test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.