Skip to content

feat(perf): Hide timing metrics on http #52993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Jul 17, 2023

Summary

Timing metrics for http are coming out but there are a lot and there is already a lot of keys on the span details, this will hide the timing metrics for now. We can opt-in specific ones on a case-by-case later.

Timing metrics for http are coming out, but there are a lot and there is already a lot of keys on the span details, this will hide the timing metrics for now until we can better pick which ones to show vs. others.
@k-fish k-fish requested a review from a team July 17, 2023 18:11
@k-fish k-fish requested a review from a team as a code owner July 17, 2023 18:11
@k-fish k-fish removed the request for review from a team July 17, 2023 18:12
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 17, 2023
Copy link
Contributor

@Abdkhan14 Abdkhan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k-fish k-fish enabled auto-merge (squash) July 17, 2023 18:17
@k-fish k-fish merged commit 145df55 into master Jul 17, 2023
@k-fish k-fish deleted the feat/perf-hide-http-timing-metrics branch July 17, 2023 18:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants