Skip to content

fix(group-attributes): log metric when post_save.send(update_fields=["status", "subs"]) is called for group #52996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

barkbarkimashark
Copy link
Contributor

Was looking at the incorrect kwargs key when post_save.send() was called.

@barkbarkimashark barkbarkimashark requested a review from a team as a code owner July 17, 2023 18:25
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 17, 2023
@barkbarkimashark barkbarkimashark enabled auto-merge (squash) July 17, 2023 18:44
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #52996 (9481df4) into master (6affbee) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #52996      +/-   ##
==========================================
+ Coverage   77.06%   77.76%   +0.69%     
==========================================
  Files        4936     4934       -2     
  Lines      207367   207320      -47     
  Branches    35426    35424       -2     
==========================================
+ Hits       159808   161221    +1413     
+ Misses      42392    41053    -1339     
+ Partials     5167     5046     -121     
Impacted Files Coverage Δ
...pp/components/events/eventReplay/replayPreview.tsx 95.83% <ø> (ø)
static/app/utils/replays/replayReader.tsx 75.00% <ø> (ø)
...app/views/performance/transactionSummary/utils.tsx 81.08% <ø> (ø)
static/app/views/replays/replayTable/tableCell.tsx 88.88% <ø> (ø)
src/sentry/api/endpoints/project_team_details.py 100.00% <100.00%> (ø)
src/sentry/apidocs/examples/project_examples.py 100.00% <100.00%> (ø)
src/sentry/issues/attributes.py 78.94% <100.00%> (+8.77%) ⬆️

... and 502 files with indirect coverage changes

@barkbarkimashark barkbarkimashark merged commit 4ea79c8 into master Jul 17, 2023
@barkbarkimashark barkbarkimashark deleted the sharky/group-attributes-log-fix branch July 17, 2023 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants