feat(secrecy): enable data secrecy for organizations #53322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53322 +/- ##
=======================================
Coverage 79.54% 79.54%
=======================================
Files 4941 4941
Lines 208709 208761 +52
Branches 35549 35560 +11
=======================================
+ Hits 166009 166058 +49
+ Misses 37637 37636 -1
- Partials 5063 5067 +4
|
cathteng
force-pushed
the
cathy/superuser/data-secrecy
branch
from
d3d1f19 to
bcf59c6
Compare
cathteng
force-pushed
the
cathy/superuser/data-secrecy
branch
from
d194673 to
386213c
Compare
dashed
reviewed
Jul 21, 2023
dashed
reviewed
Jul 21, 2023
cathteng
force-pushed
the
cathy/superuser/data-secrecy
branch
from
4fa31ed to
e8eaaa5
Compare
dashed
approved these changes
Jul 24, 2023
dcramer
reviewed
Jul 24, 2023
src/sentry/api/exceptions.py
Outdated
| @@ -85,6 +85,11 @@ class SuperuserRequired(SentryAPIException): | |||
| message = "You need to re-authenticate for superuser." | |||
|
|
|||
|
|
|||
| class DataSecrecyError(SentryAPIException): | |||
| status_code = status.HTTP_418_IM_A_TEAPOT | |||
There was a problem hiding this comment.
shouldnt this be a 401? or 403?
dashed
approved these changes
Jul 24, 2023
leedongwei
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.