Skip to content

feat(dynamic-sampling): Improve check am2 compatibility #53414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jul 24, 2023

This PR improves the AM2 compatibility check in the following way:

  • Adds new fields to the blacklist.
  • Implements search by fields.
  • Adds support for checking compatible and incompatible projects.

Closes https://github.com/getsentry/getsentry/issues/11048

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #53414 (6e43d10) into master (d16d615) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53414      +/-   ##
==========================================
- Coverage   79.55%   79.54%   -0.01%     
==========================================
  Files        4942     4941       -1     
  Lines      208639   208930     +291     
  Branches    35544    35580      +36     
==========================================
+ Hits       165975   166193     +218     
- Misses      37605    37660      +55     
- Partials     5059     5077      +18     
Files Changed Coverage Δ
src/sentry/tasks/check_am2_compatibility.py 59.90% <100.00%> (+18.84%) ⬆️

... and 75 files with indirect coverage changes

@iambriccardo iambriccardo requested a review from obostjancic July 25, 2023 07:54
@iambriccardo iambriccardo marked this pull request as ready for review July 25, 2023 07:54
@iambriccardo iambriccardo merged commit dbe033c into master Jul 25, 2023
@iambriccardo iambriccardo deleted the riccardo/feat/improve-check-am2 branch July 25, 2023 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants