Skip to content

chore(replay): Remove unicode from slack View Replays link #53518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged

chore(replay): Remove unicode from slack View Replays link #53518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/integrations/message_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def build_attachment_replay_link(
referrer = EXTERNAL_PROVIDERS[ExternalProviders.SLACK]
replay_url = f"{group.get_absolute_url()}replays/?referrer={referrer}"

return f"\n\n{url_format.format(text='⏵ View Replays', url=absolute_uri(replay_url))}"
return f"\n\n{url_format.format(text='View Replays', url=absolute_uri(replay_url))}"

return None

Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/integrations/slack/test_message_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def test_build_replay_issue(self):
attachments = SlackIssuesMessageBuilder(event.group, event).build()
assert (
attachments["text"]
== f"\n\n<http://testserver/organizations/baz/issues/{event.group.id}/replays/?referrer=slack|⏵ View Replays>"
== f"\n\n<http://testserver/organizations/baz/issues/{event.group.id}/replays/?referrer=slack|View Replays>"
)

def test_build_performance_issue_color_no_event_passed(self):
Expand Down