Skip to content

feat(integration-slack): store request error counts and disable on broken #53619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 102 commits into from
Closed

feat(integration-slack): store request error counts and disable on broken #53619

wants to merge 102 commits into from

Conversation

chloeho7
Copy link
Contributor

@chloeho7 chloeho7 commented Jul 26, 2023 •
edited
Loading

Continuing #52994 after revert

Continuing #51126
Milestone 1 of Notify on Disabled Integration project

Implementing IntegrationRequestBuffer using Redis for logging errors and detecting broken integrations to be disabled. Request buffer stores daily aggregate error, fatal and success counts for an integration for 30 days. If an integration consistently fails for 7 days or has a fatal response, then the integration is broken. Later users will be alerted of broken integrations with an email or in-app.

Disabling implemented under feature flag "slack-disable-on-broken".
Conditions for logging Implemented in BaseApiClient and SlackClient.

chloeho7 and others added 30 commits July 12, 2023 14:35
@chloeho7
from https://github.com/getsentry/sentry/pull/51126/files with fatal …
1add83f 
…_count
@chloeho7
adding fatal flag, integration id and uninstall
f5067dd
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
c215063
@chloeho7
adding slack
6aa9d08
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
aadad52
@chloeho7
adding mandatory integration id to slack and test cases
5a5b875
@getsantry
🛠️ apply pre-commit fixes
d2f2e32
@getsantry
🛠️ apply pre-commit fixes
f18dc24
@chloeho7
making buffer legit
71de356
@getsantry
🛠️ apply pre-commit fixes
1e7a359
@chloeho7
adding uninstall when broken
bf9d3fa
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
c147717
@getsantry
🛠️ apply pre-commit fixes
5dd5132
@getsantry
🛠️ apply pre-commit fixes
c2c1a50
@chloeho7
disabling Integration
0e6138d
@getsantry
🛠️ apply pre-commit fixes
d3108c0
@ceorourke
pass integration_id and get rpcintegration
f1cb088
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
8b3ab28
@chloeho7
making integrationid optional
cbd9169
@chloeho7
making integrationid optional
77975f7
@chloeho7
fixing is response error
9ace2ec
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
fd59006
@getsantry
🛠️ apply pre-commit fixes
42e4978
@chloeho7
adding slack fatal errors and fixing tests
a0b7781
@getsantry
🛠️ apply pre-commit fixes
976c1d3
@chloeho7
fixing buffer key
7687f0f
@chloeho7
fixing buffer var names
5bbf526
@chloeho7
record_request and buffer fixes
fd82865
@getsantry
🛠️ apply pre-commit fixes
b7f6442
@getsantry
🛠️ apply pre-commit fixes
d432edc
chloeho7 and others added 24 commits July 20, 2023 14:32
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
4053ef4
@getsantry
🛠️ apply pre-commit fixes
6c170ef
@getsantry
🛠️ apply pre-commit fixes
8f5db70
@chloeho7
is_response_error code
2e207fe
@chloeho7
cleaning up comments and updating docstring
f08061d
@chloeho7
updating docstring and is_response_success
b301b12
@ceorourke
fix tests
008d2b6
@ceorourke
typing
bb1a836
@chloeho7
fixing conf/server diff and removing fatal flag
b296fb8
@chloeho7
is_considered error and feature flag changes
22de707
@chloeho7
test cases for slow but not broken
46f6863
@chloeho7
sign change
ae31737
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
34f4c7e
@chloeho7
fixing typing errors
1449055
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
7acf507
@chloeho7
fixing tests with new types
5f9ab43
@chloeho7
Update base.py with rpc_integration is none case
43a0ff1
@chloeho7
Update base.py w is none
2fd0ec2
@chloeho7
fixing typing
702d8d2
@chloeho7
Update __init__.py
768731e
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
03a1936
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
3ca3e64
@chloeho7
Merge branch 'master' into chloedisablenotifyslack
fad3435
@chloeho7
adding try catch for cluster init
feec59c
@chloeho7 chloeho7 requested a review from a team as a code owner July 26, 2023 16:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 26, 2023
@chloeho7 chloeho7 closed this Jul 26, 2023
@chloeho7 chloeho7 deleted the chloedisablenotifyslack branch July 26, 2023 17:03
@chloeho7 chloeho7 restored the chloedisablenotifyslack branch July 26, 2023 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chloeho7 @ceorourke