fix(replays): add prompt if user needs SDK upgrade #53672
Conversation
github-actions
bot
added
the
Scope: Frontend
There was a problem hiding this comment.
I'm wondering if this is a bit too subtle? Thoughts on using an Alert banner with the message?
We should also link to something as well... maybe https://docs.sentry.io/platforms/javascript/install/npm/? We don't really have any upgrading docs unfortunately.
static/app/views/replays/list/replaysErroneousDeadRageCards.tsx
Outdated
Show resolved
Hide resolved
| ${props => | ||
| props.gridRows | ||
| ? `grid-template-rows: ${props.gridRows};` | ||
| : 'grid-template-rows: 44px max-content'} |
| border-radius: 0px; | ||
| border-width: 1px 0 1px 0; |
There was a problem hiding this comment.
the styled alert looks better inside the cards 👍
can you also check how it looks inside the main table? that might not have a min-height but idk how the extra border will be.
There was a problem hiding this comment.
Looks like our issues stream does not include the top border:
There was a problem hiding this comment.
do we want to remove the top border for both alerts here?
There was a problem hiding this comment.
rn looks like this
There was a problem hiding this comment.
issue stream also has that margin. i don't love the margin though
There was a problem hiding this comment.
i can add in that margin to the style for continuity
There was a problem hiding this comment.
how's this? i tried removing top border too but it looks weird without the top border - the table header's bottom border doesn't fill the entire row for some reason
There was a problem hiding this comment.
discussed offline: @ryan953 suggested keeping rage click table alert as is, but removing margin & bottom border for big replay table
michellewzhang
force-pushed
the
mz/sdk-update-message
branch
2 times, most recently
from
3a70dea to
350905f
Compare
| @@ -28,6 +31,8 @@ import { | |||
| import {ReplayColumn} from 'sentry/views/replays/replayTable/types'; | |||
| import type {ReplayListRecord} from 'sentry/views/replays/types'; | |||
|
|
|||
| export const MIN_DEAD_RAGE_CLICK_SDK = '7.60.1'; | |||
There was a problem hiding this comment.
was planning to originally but not anymore -- i'll get rid of it
michellewzhang
force-pushed
the
mz/sdk-update-message
branch
from
350905f to
0486d56
Compare
fixes getsentry/team-replay#126 by informing users they need to upgrade their SDK to see rage/dead click data if this applies.
no results but SDK version is good:
no results and SDK version too low:
error alert also updated:
