Skip to content

ref(metrics-layer): Test the span metric charts too #54045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

wmak
Copy link
Member

@wmak wmak commented Aug 2, 2023

  • This adds the metrics-layer feature flag to the span metrics event-stats tests too

- This adds the metrics-layer feature flag to the span metrics
  event-stats tests too
@wmak wmak requested a review from a team August 2, 2023 18:23
@wmak wmak marked this pull request as ready for review August 2, 2023 18:23
@wmak wmak requested a review from a team August 2, 2023 18:23
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #54045 (910e4ae) into master (e658f63) will increase coverage by 0.00%.
Report is 31 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #54045   +/-   ##
=======================================
  Coverage   79.53%   79.54%           
=======================================
  Files        4974     4974           
  Lines      210394   210386    -8     
  Branches    35836    35832    -4     
=======================================
+ Hits       167339   167347    +8     
+ Misses      37907    37895   -12     
+ Partials     5148     5144    -4     
Files Changed Coverage Δ
...tatic/app/views/replays/replayTable/headerCell.tsx 66.66% <ø> (ø)
static/app/views/replays/replayTable/index.tsx 88.23% <ø> (ø)
static/app/views/replays/replayTable/tableCell.tsx 88.88% <ø> (ø)

... and 31 files with indirect coverage changes

@wmak wmak merged commit 021fc81 into master Aug 3, 2023
@wmak wmak deleted the wmak/ref/test-metrics-layer-for-span-metric-charts branch August 3, 2023 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants