Skip to content

feat(most-helpful-event): Add option in user settings to change default issue event #54048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

17hogeju
Copy link
Contributor

@17hogeju 17hogeju commented Aug 2, 2023

Closes #53913

Add the ability to save a user option for the default event shown on the issue details page.

The options are:

  • recommended (default)
  • latest
  • oldest

@17hogeju 17hogeju requested a review from malwilley August 2, 2023 18:47
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #54048 (211082d) into master (af54b69) will increase coverage by 0.02%.
Report is 9 commits behind head on master.
The diff coverage is 90.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54048      +/-   ##
==========================================
+ Coverage   79.58%   79.61%   +0.02%     
==========================================
  Files        4984     4984              
  Lines      210784   210716      -68     
  Branches    35890    35872      -18     
==========================================
+ Hits       167750   167759       +9     
+ Misses      37892    37810      -82     
- Partials     5142     5147       +5     
Files Changed Coverage Δ
src/sentry/replays/validators.py 100.00% <ø> (ø)
src/sentry/testutils/silo.py 85.00% <ø> (ø)
static/app/views/alerts/rules/metric/ruleForm.tsx 71.60% <ø> (ø)
src/sentry/services/hybrid_cloud/auth/impl.py 88.77% <66.66%> (-0.74%) ⬇️
src/sentry/services/hybrid_cloud/auth/service.py 81.48% <80.00%> (-0.52%) ⬇️
src/sentry/api/base.py 92.35% <100.00%> (+0.02%) ⬆️
src/sentry/api/endpoints/user_details.py 96.42% <100.00%> (+0.02%) ⬆️
src/sentry/api/serializers/models/user.py 98.72% <100.00%> (+<0.01%) ⬆️
src/sentry/auth/providers/saml2/generic/views.py 58.53% <100.00%> (+27.76%) ⬆️
src/sentry/db/models/base.py 89.43% <100.00%> (+0.08%) ⬆️
... and 3 more

... and 7 files with indirect coverage changes

@malwilley malwilley changed the title build(most-helpful-event): Add option in user settings to change defa… feat(most-helpful-event): Add option in user settings to change default issue event Aug 2, 2023
@17hogeju 17hogeju marked this pull request as ready for review August 2, 2023 22:06
@17hogeju 17hogeju merged commit f793a73 into master Aug 3, 2023
@17hogeju 17hogeju deleted the julia/user-option branch August 3, 2023 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings backend: Add a user option to configure the default event shown on the issue page
2 participants