Skip to content

ref(plugins): Minor fixes for plugins #54217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 4, 2023

Conversation

leeandher
Copy link
Member

This PR is a variety of small edits while investigating plugin webhooks.

  • Typing on the middleware
  • Removing unused features from GitLab listing
  • Add logging to check for dead code on Github/Bitbucket (which I suspect were migrated)
  • Rename Plugin views to avoid naming collision with integration views

@leeandher leeandher requested a review from a team as a code owner August 4, 2023 19:59
@leeandher leeandher requested a review from a team August 4, 2023 19:59
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 4, 2023
@leeandher leeandher changed the title ref(plugins): Clean up for plugin code ref(plugins): Minor fixes for plugins Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #54217 (9a71c09) into master (c0e47b1) will increase coverage by 0.02%.
Report is 55 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54217      +/-   ##
==========================================
+ Coverage   79.60%   79.63%   +0.02%     
==========================================
  Files        4989     4982       -7     
  Lines      210817   211110     +293     
  Branches    35908    35962      +54     
==========================================
+ Hits       167830   168107     +277     
- Misses      37831    37837       +6     
- Partials     5156     5166      +10     
Files Changed Coverage Δ
...try/middleware/integrations/integration_control.py 100.00% <100.00%> (ø)

... and 56 files with indirect coverage changes

@leeandher leeandher merged commit bdbec4d into master Aug 4, 2023
@leeandher leeandher deleted the leander/hc-plugin-investigation branch August 4, 2023 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants