Skip to content

chore(hybrid-cloud): Add using to various transaction.atomic blocks #54465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

dashed
Copy link
Member

@dashed dashed commented Aug 9, 2023

This makes it explicitly clear which database to use in the split database world.

@dashed dashed requested a review from a team August 9, 2023 17:48
@dashed dashed self-assigned this Aug 9, 2023
@dashed dashed requested review from a team as code owners August 9, 2023 17:48
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #54465 (f7ea121) into master (4215953) will increase coverage by 0.71%.
Report is 6 commits behind head on master.
The diff coverage is 44.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54465      +/-   ##
==========================================
+ Coverage   78.95%   79.67%   +0.71%     
==========================================
  Files        4989     4989              
  Lines      211613   211665      +52     
  Branches    36066    36074       +8     
==========================================
+ Hits       167076   168638    +1562     
+ Misses      39254    37837    -1417     
+ Partials     5283     5190      -93     
Files Changed Coverage Δ
src/sentry/auth/helper.py 91.39% <0.00%> (-0.24%) ⬇️
src/sentry/web/frontend/accounts.py 51.67% <0.00%> (-0.68%) ⬇️
...ntry/api/endpoints/organization_member/__init__.py 93.84% <100.00%> (ø)

... and 72 files with indirect coverage changes

@dashed dashed merged commit 6e6e69e into master Aug 9, 2023
@dashed dashed deleted the hybrid-cloud/0-add-using-to-transaction-atomic branch August 9, 2023 20:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants