fix(perf-issues): Allow http timings small drift #54547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems there are times where the http timings are slightly off from span duration, in the millisecond range. This is likely due to the differences between timing the fetch operations and how PerformanceNetworkTiming works, but for now we can ease of the exit condition so we get subtimings when it's really close.
github-actions
bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems there are times where the http timings are slightly off from span duration, in the millisecond range. This is likely due to the differences between timing the fetch operations and how PerformanceNetworkTiming works, but for now we can ease off the exit condition by a few milliseconds so we get subtimings when it's really close.
Screenshots
Timings won't get generated if they are outside the bounds of the span at all currently.
