feat(backup): Add ForeignKeyComparator #54558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
azaslavsky
force-pushed
the
azaslavsky/backup/ignored_comparator
branch
from
25b28a6 to
7eeea6b
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/foreign_key_comparator
branch
from
48a9d15 to
ebb9fde
Compare
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
azaslavsky
force-pushed
the
azaslavsky/backup/ignored_comparator
branch
from
7eeea6b to
225ff95
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/foreign_key_comparator
branch
from
ebb9fde to
fe35ff0
Compare
azaslavsky
removed
Scope: Frontend
azaslavsky
force-pushed
the
azaslavsky/backup/ignored_comparator
branch
from
225ff95 to
e421f0e
Compare
azaslavsky
force-pushed
the
azaslavsky/backup/foreign_key_comparator
branch
from
fe35ff0 to
1e69cf7
Compare
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54558 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 5000 5000
Lines 212243 212300 +57
Branches 36159 36173 +14
=======================================
+ Hits 169331 169388 +57
+ Misses 37707 37703 -4
- Partials 5205 5209 +4
|
Base automatically changed from
azaslavsky/backup/ignored_comparator
to
master
August 11, 2023 23:55
Given two instances of a model that are being validated for equality, we want the foreign keys to be correct relatively (ie, they point to the same model in the respective models' JSON blobs), not absolutely (ie, they are literally the same integer). By creating maps that store the relations between pks and ordinals, we can easily check that the models point to match their respective ordinals regardless of the actual pk numbers. Issue: getsentry/team-ospo#171
azaslavsky
force-pushed
the
azaslavsky/backup/foreign_key_comparator
branch
from
1e69cf7 to
258c205
Compare
hubertdeng123
approved these changes
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given two instances of a model that are being validated for equality, we want the foreign keys to be correct relatively (ie, they point to the same model in the respective models' JSON blobs), not absolutely (ie, they are literally the same integer). By creating maps that store the relations between pks and ordinals, we can easily check that the models point to match their respective ordinals regardless of the actual pk numbers.
Issue: getsentry/team-ospo#171