Skip to content

ref(query-builder): Cleanup query_framework code #54586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

wmak
Copy link
Member

@wmak wmak commented Aug 10, 2023

  • This is mostly a cleanup that came about trying to add more logic around the query frameworks to query both transactions & span data in a single request. But we realized that sorting/querying wouldn't work so reverted all that. This is still good cleanup since it removes a bunch of code repeat

- This is mostly a cleanup that came about trying to add more logic
  around the query frameworks to query both transactions & span data in
  a single request. But we realized that sorting/querying wouldn't work
  so reverted all that. This is still good cleanup since it removes a
  bunch of code repeat
@wmak wmak requested review from a team August 10, 2023 20:53
@wmak wmak requested a review from a team as a code owner August 10, 2023 20:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #54586 (4a08493) into master (fc99b31) will decrease coverage by 0.02%.
Report is 7 commits behind head on master.
The diff coverage is 92.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54586      +/-   ##
==========================================
- Coverage   79.78%   79.77%   -0.02%     
==========================================
  Files        4999     4999              
  Lines      212333   212422      +89     
  Branches    36196    36194       -2     
==========================================
+ Hits       169418   169467      +49     
- Misses      37702    37748      +46     
+ Partials     5213     5207       -6     
Files Changed Coverage Δ
src/sentry/search/events/builder/metrics.py 86.52% <92.30%> (+3.54%) ⬆️

... and 49 files with indirect coverage changes

@wmak wmak merged commit b990231 into master Aug 15, 2023
@wmak wmak deleted the wmak/ref/cleanup-query-framework-code branch August 15, 2023 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants