Skip to content

feat(integrations): analytics for links in notify when disabled integrations #54640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2023
Merged

feat(integrations): analytics for links in notify when disabled integrations #54640

merged 3 commits into from
Aug 11, 2023

Conversation

chloeho7
Copy link
Contributor

No description provided.

@chloeho7 chloeho7 requested a review from a team as a code owner August 11, 2023 17:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Merging #54640 (460c35b) into master (6eef8c3) will increase coverage by 1.66%.
Report is 41 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 460c35b differs from pull request most recent head 08b5d22. Consider uploading reports for the commit 08b5d22 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #54640      +/-   ##
==========================================
+ Coverage   78.08%   79.74%   +1.66%     
==========================================
  Files        4995     4996       +1     
  Lines      212164   212254      +90     
  Branches    36163    36181      +18     
==========================================
+ Hits       165669   169267    +3598     
+ Misses      41229    37777    -3452     
+ Partials     5266     5210      -56
Files Changed Coverage Δ
src/sentry/integrations/notify_disable.py 80.00% <100.00%> (+0.83%) ⬆️

... and 267 files with indirect coverage changes

ceorourke
ceorourke reviewed Aug 11, 2023
View reviewed changes
src/sentry/integrations/notify_disable.py Outdated
@@ -51,15 +51,21 @@ def notify_disable(
integration_slug if "sentry-app" in redis_key and integration_slug else integration_name,
)

referrrer = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol this has one too many r's

ceorourke
ceorourke approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the lil typo

@chloeho7 chloeho7 enabled auto-merge (squash) August 11, 2023 21:42
@chloeho7 chloeho7 merged commit 6ae49b4 into master Aug 11, 2023
@chloeho7 chloeho7 deleted the chloe/email-analytics branch August 11, 2023 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ceorourke ceorourke ceorourke approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
Notify on Disabled Integration
Development

Successfully merging this pull request may close these issues.
2 participants
@chloeho7 @ceorourke