Skip to content

ref(statistical-detectors): Clean up statistical detectors calculation #54694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

Zylphrex
Copy link
Member

Clean up the calculations so that it's able to process things 1 at a time instead of an arbitrary grouping.

Clean up the calculations so that it's able to process things 1 at a time
instead of an arbitrary grouping.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #54694 (ba21ddd) into master (722aee0) will increase coverage by 25.44%.
The diff coverage is 100.00%.

❗ Current head ba21ddd differs from pull request most recent head 99c197e. Consider uploading reports for the commit 99c197e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #54694       +/-   ##
===========================================
+ Coverage   54.33%   79.77%   +25.44%     
===========================================
  Files        4985     5001       +16     
  Lines      212028   212236      +208     
  Branches    36151    36166       +15     
===========================================
+ Hits       115200   169318    +54118     
+ Misses      93861    37704    -56157     
- Partials     2967     5214     +2247     
Files Changed Coverage Δ
src/sentry/statistical_detectors/detector.py 100.00% <100.00%> (+61.53%) ⬆️

... and 1774 files with indirect coverage changes

@Zylphrex Zylphrex requested review from udameli and a team August 15, 2023 15:15
@Zylphrex Zylphrex enabled auto-merge (squash) August 15, 2023 17:26
@Zylphrex Zylphrex merged commit f2cc9f8 into master Aug 15, 2023
@Zylphrex Zylphrex deleted the txiao/ref/clean-up-statistical-detectors-computation branch August 15, 2023 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants