Skip to content

feat(tracing-without-performance): Replay compatibility and ui improvements. #54700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

Abdkhan14
Copy link
Contributor

@Abdkhan14 Abdkhan14 commented Aug 14, 2023

This PR aims to make the new orphan error views compatible with traceview in replayDetails and adds hidden messages for orphan error search in traceviews, under the feature flag organizations:performance-tracing-without-performance.

Testing with yarn dev-ui:

  • Orphan errors traceview for testing search hidden messages: link
  • Replay details trace should now load: link

Changes:
Screenshot 2023-08-14 at 1 00 58 PM
Screenshot 2024-08-04 at 11 49 00 PM

Context:
We now want to show trace views for traces that contain orphan errors. JIRA-TICKET

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 14, 2023
@Abdkhan14 Abdkhan14 marked this pull request as ready for review August 14, 2023 17:07
@Abdkhan14 Abdkhan14 requested review from a team as code owners August 14, 2023 17:07
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment r.e. i18n before this goes in, but I tested it locally and the replays are showing fine as well as the hidden messages

@Abdkhan14 Abdkhan14 enabled auto-merge (squash) August 15, 2023 18:07
@Abdkhan14 Abdkhan14 merged commit 7518d18 into master Aug 15, 2023
@Abdkhan14 Abdkhan14 deleted the abdk/tracing-w/o-performance-ui branch August 15, 2023 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants