feat(issues): Track weekly report sends and clicks #54744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
scttcper
commented
Aug 15, 2023
| @@ -89,7 +88,6 @@ def test_with_empty_string_user_option(self): | |||
| assert self.organization.name in message.subject | |||
|
|
|||
| @with_feature("organizations:customer-domains") | |||
| @with_feature("organizations:weekly-email-refresh") | |||
There was a problem hiding this comment.
went looking for this flag, seems to be gone
scefali
reviewed
Aug 15, 2023
src/sentry/tasks/weekly_reports.py
Outdated
| @@ -739,6 +741,8 @@ def render_template_context(ctx, user_id): | |||
| "organizations:session-replay", ctx.organization | |||
| ) and features.has("organizations:session-replay-weekly-email", ctx.organization) | |||
|
|
|||
| notification_uuid = "".join(random.choices(string.ascii_letters + string.digits, k=16)) | |||
There was a problem hiding this comment.
@scttcper we should make this into some utility function cause we'll need it a lot
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54744 +/- ##
==========================================
- Coverage 79.78% 79.78% -0.01%
==========================================
Files 5000 5001 +1
Lines 212247 212262 +15
Branches 36162 36163 +1
==========================================
+ Hits 169335 169344 +9
- Misses 37704 37710 +6
Partials 5208 5208
|
scefali
approved these changes
Aug 15, 2023
jangjodi
approved these changes
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weekly_report. Previously there was a mix ofweekly-reportweekly_reportandweekly_emailfixes #50443