ref(ui): Enhance Carousel component #54747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-enhance-carousel-component
branch
from
d095d30 to
bb1829d
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-enhance-carousel-component
branch
from
bb1829d to
1159064
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-enhance-carousel-component
branch
2 times, most recently
from
7d2c13f to
bf518e9
Compare
vuluongj20
reviewed
Aug 15, 2023
Comment on lines
+9
to
+22
| window.IntersectionObserver = class IntersectionObserver { | ||
| root = null; | ||
| rootMargin = ''; | ||
| thresholds = []; | ||
| takeRecords = jest.fn(); | ||
|
|
||
| constructor(cb: IntersectionObserverCallback) { | ||
| // @ts-expect-error The callback wants just way too much stuff for our simple mock | ||
| intersectionOnbserverCb = cb; | ||
| } | ||
| observe() {} | ||
| unobserve() {} | ||
| disconnect() {} | ||
| }; |
There was a problem hiding this comment.
Do we still need this if it's in tests/js/setup?
There was a problem hiding this comment.
yeah since I need to override the callback
vuluongj20
reviewed
Aug 15, 2023
static/app/components/carousel.tsx
Outdated
| ), | ||
| { | ||
| root: ref.current, | ||
| threshold: [0, visibleRatio, 1], |
There was a problem hiding this comment.
hmm why do we need the 0 & 1 thresholds? looks like we only need to update visibility when the interaction ratio crosses visibleRatio, so shouldn't [visibleRatio] suffice?
1. Record a visibility list and use that to determine if we need to
scroll left or right. This has the advantage setting isAtStart and
isAtEnd as state in that we're able to be a little smarter about if
an element is visibile or not.
In addition here we've added a `visibleRatio` prop to the component,
which lets you customize this value.
2. Use scrollIntoView. This is more robust and allows us to set a
`scroll-margin` on the children.
3. Update tests to test for button clicks
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-enhance-carousel-component
branch
from
bf518e9 to
d95d59e
Compare
vuluongj20
approved these changes
Aug 15, 2023
evanpurkhiser
deleted the
evanpurkhiser/ref-ui-enhance-carousel-component
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record a visibility list and use that to determine if we need to scroll left or right. This has the advantage setting isAtStart and isAtEnd as state in that we're able to be a little smarter about if an element is visibile or not.
In addition here we've added a
visibleRatioprop to the component, which lets you customize this value.Use scrollIntoView. This is more robust and allows us to set a
scroll-marginon the children.Update tests to test for button clicks