Skip to content

sample-event: try synchronous kafka producing #54748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Aug 15, 2023

  • when creating a sample event, try producing synchronously, since when done through the sample_event endpoint, we may not finish flushing before the request thread is terminated.
  • can test this on S4S to see if fixes issue, and quickly revert before it makes it to canary before it can cause problems, but I think it should be fine?

Note: my understanding of kafka / how Django uWSGI lifecycles work is not expert, so my analysis/assumptions here may be off.

@JoshFerge JoshFerge requested a review from a team as a code owner August 15, 2023 03:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #54748 (7e204dc) into master (43088e2) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #54748   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files        5000     5000           
  Lines      212248   212249    +1     
  Branches    36162    36162           
=======================================
+ Hits       169340   169342    +2     
+ Misses      37700    37696    -4     
- Partials     5208     5211    +3     
Files Changed Coverage Δ
src/sentry/eventstream/kafka/backend.py 68.75% <0.00%> (-0.88%) ⬇️
src/sentry/eventstream/snuba.py 85.00% <ø> (ø)

... and 2 files with indirect coverage changes

@JoshFerge JoshFerge merged commit af91403 into master Aug 15, 2023
@JoshFerge JoshFerge deleted the jferg/sample-event-fix-q branch August 15, 2023 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants