Skip to content

feat(alerts): Emit alert.sent analytic on incidents #55479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Aug 30, 2023

fixes #54417

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 30, 2023
@scttcper scttcper changed the title Scttcper/alert sent incidents feat(alerts): Emit alert.sent analytic on incidents Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #55479 (b01cbfc) into master (2631598) will increase coverage by 0.33%.
Report is 24 commits behind head on master.
The diff coverage is 89.36%.

@@            Coverage Diff             @@
##           master   #55479      +/-   ##
==========================================
+ Coverage   79.78%   80.11%   +0.33%     
==========================================
  Files        5042     5045       +3     
  Lines      215884   216034     +150     
  Branches    36512    36521       +9     
==========================================
+ Hits       172238   173080     +842     
+ Misses      38327    37675     -652     
+ Partials     5319     5279      -40     
Files Changed Coverage
...entry/services/hybrid_cloud/integration/service.py ø
...c/sentry/services/hybrid_cloud/integration/impl.py 50.00%
...c/sentry/integrations/slack/utils/notifications.py 66.66%
src/sentry/incidents/action_handlers.py 92.30%
src/sentry/analytics/events/__init__.py 100.00%
src/sentry/analytics/events/alert_sent.py 100.00%
src/sentry/integrations/msteams/utils.py 100.00%
src/sentry/integrations/opsgenie/utils.py 100.00%
src/sentry/integrations/pagerduty/utils.py 100.00%
src/sentry/rules/actions/notify_event_service.py 100.00%

@scttcper scttcper requested review from scefali and jangjodi August 30, 2023 19:34
@scttcper scttcper marked this pull request as ready for review August 30, 2023 19:34
@scttcper scttcper requested review from a team as code owners August 30, 2023 19:34
@scttcper scttcper merged commit a269db2 into master Sep 5, 2023
@scttcper scttcper deleted the scttcper/alert-sent-incidents branch September 5, 2023 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notification_uuid to IncidentActivity
3 participants