Skip to content

feat(alerts): Add notification_uuid and alert_id to notification_sent analytics #55937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2023
Merged

feat(alerts): Add notification_uuid and alert_id to notification_sent analytics #55937

merged 3 commits into from
Sep 12, 2023

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Sep 8, 2023 •
edited
Loading

fixes #54422

@scttcper scttcper requested a review from a team as a code owner September 8, 2023 20:12
@scttcper scttcper marked this pull request as draft September 8, 2023 20:12
@scttcper scttcper added the WIP label Sep 8, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #55937 (2044ec6) into master (24ec43b) will increase coverage by 0.03%.
Report is 63 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #55937      +/-   ##
==========================================
+ Coverage   79.94%   79.98%   +0.03%     
==========================================
  Files        5061     5062       +1     
  Lines      217467   217738     +271     
  Branches    36806    36860      +54     
==========================================
+ Hits       173853   174155     +302     
+ Misses      38290    38244      -46     
- Partials     5324     5339      +15
Files Changed Coverage
...entry/integrations/discord/actions/notification.py ø
src/sentry/integrations/discord/analytics.py ø
src/sentry/integrations/msteams/analytics.py ø
src/sentry/integrations/slack/analytics.py ø
src/sentry/mail/analytics.py ø
src/sentry/notifications/notifications/base.py ø
src/sentry/notifications/notifications/rules.py ø
src/sentry/notifications/notifications/digest.py 66.66%

@scttcper scttcper changed the title fix(alerts): Add notification uuid to notification_sent analytics feat(alerts): Add notification uuid to notification_sent analytics Sep 8, 2023
@scttcper scttcper marked this pull request as ready for review September 8, 2023 23:27
@scttcper scttcper requested review from scefali and jangjodi September 8, 2023 23:27
scttcper
scttcper commented Sep 8, 2023
View reviewed changes
src/sentry/mail/analytics.py
Comment on lines -17 to -18
# Remove after IssueAlertFallbackExperiment
analytics.Attribute("fallback_experiment", required=False),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer referenced anywhere

@scttcper scttcper changed the title feat(alerts): Add notification uuid to notification_sent analytics feat(alerts): Add notification_uuid and alert_id to notification_sent analytics Sep 11, 2023
@scttcper scttcper removed the WIP label Sep 11, 2023
@scttcper scttcper merged commit 2b04cf5 into master Sep 12, 2023
@scttcper scttcper deleted the scttcper/notifiation-sent-uuid branch September 12, 2023 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jangjodi jangjodi jangjodi approved these changes

@scefali scefali Awaiting requested review from scefali

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
Notification Analytics Milestone 2
Development

Successfully merging this pull request may close these issues.

Add notification_uuid to notification_sent Analytic
3 participants
@scttcper @scefali @jangjodi