migration(crons): Add MonitorIncident table #56403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
src/sentry/monitors/models.py
Outdated
Comment on lines
602
to
603
| opening_checkin = FlexibleForeignKey("sentry.MonitorCheckIn", related_name="created_incidents") | ||
| closing_checkin = FlexibleForeignKey( |
There was a problem hiding this comment.
These feel like misnomers, I think we probably want 'starting_checkinandresolved_checkin`
and for good measure, we should probably add some comments to these fields to clearly indicate which checkins in the lifecycle of an incident these would be.
Also Important, these should probably be nullablabe since the checkins will be removed, in which case, I think we almost definitely would probably want to either
- Also remove the incident when any checkins are removed
- Keep start and end date and allow empty start and end check ins
| closing_checkin = FlexibleForeignKey( | ||
| "sentry.MonitorCheckIn", related_name="closed_incidents", null=True | ||
| ) | ||
| grouphash = models.CharField(max_length=32) |
There was a problem hiding this comment.
Can we just use a UUID field?
There was a problem hiding this comment.
I guess but wanted to keep it consistent with
sentry/src/sentry/models/grouphash.py
Line 25 in 2cba1ab
|
Closing in favor of #56435 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
MonitorIncidentTableto keep track of open monitor incidents + display them on the timeline view.If a
failurethreshold is set, we will open anincidentand tag it with the appropriatehashand reference thecheckinthat caused it to pass the threshold.If a
recoverythreshold is set, we will find anyincidentwith the appropriatehashand set it as theclosing_checkin.In the future, if no thresholds are set, we will move to this behavior. But for now, we will keep existing behavior as-is.
The
thresholdscan be derived from thecheckinconfigs, though we may want to add them as top level fields.Closes #56402