Skip to content

logging(apis): better logging for api failures #56432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Sep 18, 2023

This PR ensures we pass in the URL an the integration id into failure log messages

@scefali scefali requested a review from a team as a code owner September 18, 2023 21:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #56432 (7438ab6) into master (9c83e9f) will increase coverage by 0.00%.
Report is 30 commits behind head on master.
The diff coverage is 87.50%.

❗ Current head 7438ab6 differs from pull request most recent head 5b65b3e. Consider uploading reports for the commit 5b65b3e to get more accurate results

@@           Coverage Diff           @@
##           master   #56432   +/-   ##
=======================================
  Coverage   78.62%   78.63%           
=======================================
  Files        5077     5078    +1     
  Lines      218303   218355   +52     
  Branches    36950    36962   +12     
=======================================
+ Hits       171649   171706   +57     
  Misses      41108    41108           
+ Partials     5546     5541    -5     
Files Changed Coverage
src/sentry/integrations/slack/client.py ø
src/sentry/shared_integrations/client/base.py 85.71%
src/sentry/shared_integrations/track_response.py 100.00%

@scefali scefali merged commit b72ff94 into master Sep 19, 2023
@scefali scefali deleted the logging/better-api-logging branch September 19, 2023 16:34
@sentry-io
Copy link

sentry-io bot commented Sep 19, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ApiError: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/reference/apps#create-an... sentry.tasks.process_commit_context View Issue
  • ‼️ ApiError: {"message":"403 Forbidden - Your account has been blocked."} /api/0/organizations/{organization_slug}/repos/ View Issue
  • ‼️ ApiRateLimitedError: <meta http-equiv="X-UA-Compatible" con... integration.http_response.jira View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants