Skip to content

chore(notifications): rename approval notifications to nudges in the UI #56505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2023
Merged

chore(notifications): rename approval notifications to nudges in the UI #56505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e9e58
rename approval notifications to nudges in the UI
cathteng Sep 19, 2023
7cc70f2
revert the ame change
cathteng Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/views/settings/account/notifications/fields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ export const ACCOUNT_NOTIFICATION_FIELDS: Record<string, FineTuneField> = {
defaultFieldName: 'weeklyReports',
},
approval: {
title: t('Approvals'),
description: t('Notifications from teammates that require review or approval.'),
title: t('Nudges'),
description: t('Notifications that require review or approval.'),
type: 'select',
// No choices here because it's going to have dynamic content
// Component will create choices,
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/settings/account/notifications/fields2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ export const NOTIFICATION_SETTING_FIELDS: Record<string, Field> = {
approval: {
name: 'approval',
type: 'select',
label: t('Approvals'),
label: t('Nudges'),
choices: [
['always', t('On')],
['never', t('Off')],
],
help: t('Notifications from teammates that require review or approval.'),
help: t('Notifications that require review or approval.'),
},
quota: {
name: 'quota',
Expand Down