Skip to content

fix(notifications-v2): Use notifications_service for project serializer #56717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

snigdhas
Copy link
Member

@snigdhas snigdhas commented Sep 22, 2023

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 22, 2023
@snigdhas snigdhas requested review from scefali and a team September 22, 2023 02:58
@snigdhas snigdhas marked this pull request as ready for review September 22, 2023 02:58
Copy link
Contributor

@scefali scefali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snigdhas could you add a test for this? Probably just need to add a feature flag to an existing test.

@snigdhas
Copy link
Member Author

@snigdhas could you add a test for this? Probably just need to add a feature flag to an existing test.

I'm ~85% sure this code runs but is never used anywhere - I can't find anywhere in the code where we use the value of is_subscribed. Historically, it doesn't look like this was ever included the serializer since Marcos worked on it a few years ago. I'll merge this and file a ticket to clean this up as part of the rest of the cleanup.

@snigdhas snigdhas merged commit 0edd435 into master Sep 22, 2023
@snigdhas snigdhas deleted the snigdha/bug-fix branch September 22, 2023 23:24
@snigdhas snigdhas added this to the Notification Settings 2.0 milestone Sep 22, 2023
RaduW pushed a commit that referenced this pull request Sep 25, 2023
…er (#56717)

fixes SENTRY-1627
fixes SENTRY-1628
fixes SENTRY-1629
fixes SENTRY-162A

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@sentry-io
Copy link

sentry-io bot commented Sep 26, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: get_subscriptions_for_projects() got an unexpected keyword argument 'user' /api/0/organizations/{organization_slug}/projects/ View Issue
  • ‼️ TypeError: get_subscriptions_for_projects() got an unexpected keyword argument 'user' /api/0/projects/ View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants