chore(dashboards): Bump up rate limit for the events endpoint #57876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
narsaynorath
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
I know the ticket specifically mentions big number, but presumably this also affects release health widgets. I'm not sure what the rate limit is on the sessions endpoint but we may have to address a rate limit there as well. I think the events endpoint is by far the largest offender for the 429 issue though
I can bump up the rate limit there as well if it becomes an issue |
volokluev
added a commit
that referenced
this pull request
Oct 16, 2023
I don't know how this test passed but the rate limit was bumped up in #57876 while the test was not modified. * Move the test outside of the snuba acceptance suite since it does not actually test snuba * fix the test to use the rate limit constant so it doesn't fail like this anymore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our customers have more than 15 widgets in the dashboard. All the widgets are making concurrent requests which leads to
429error returned by the server. To allow these customers use their dashboards, I'm bumping up the rate limit to 30 and concurrent rate limit to 15.Fixes #57173