Skip to content

ref(participants): Check for group list #58204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

ceorourke
Copy link
Member

Group list is an optional param so we need to check if it exists before trying to check a feature flag's status.

Fixes SENTRY-16V3

@ceorourke ceorourke requested a review from a team as a code owner October 16, 2023 22:30
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #58204 (d97048a) into master (ceae88a) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #58204      +/-   ##
==========================================
- Coverage   79.05%   79.05%   -0.01%     
==========================================
  Files        5135     5135              
  Lines      223485   223486       +1     
  Branches    37627    37628       +1     
==========================================
- Hits       176686   176680       -6     
- Misses      41141    41148       +7     
  Partials     5658     5658              
Files Coverage Δ
src/sentry/api/helpers/group_index/update.py 79.69% <66.66%> (-0.25%) ⬇️

... and 6 files with indirect coverage changes

@ceorourke ceorourke merged commit a0b928d into master Oct 16, 2023
@ceorourke ceorourke deleted the ceorourke/SENTRY-16V3 branch October 16, 2023 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants