chore(migrations): Drop unused index in Incident table #58449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Alter index_together for incident (1 constraint(s))
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_incident_id_date_added_785a850e_idx"; |
Codecov Report
@@ Coverage Diff @@
## master #58449 +/- ##
==========================================
+ Coverage 79.93% 80.57% +0.63%
==========================================
Files 5143 5144 +1
Lines 224629 224763 +134
Branches 37855 37880 +25
==========================================
+ Hits 179553 181094 +1541
+ Misses 39519 38131 -1388
+ Partials 5557 5538 -19
|
wedamija
approved these changes
Oct 19, 2023
| # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to | ||
| # have ops run this and not block the deploy. Note that while adding an index is a schema | ||
| # change, it's completely safe to run the operation after the code has deployed. | ||
| is_dangerous = True |
There was a problem hiding this comment.
This doesn't need to be dangerous, it's fast to drop an index.
isabellaenriquez
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the index on
id, date_added. This was originally added in #58207 to make a query in #58032 more efficient, however, after it was added, we determined that it was still really slow. We'll be using a different approach, so this one is no longer needed.