Skip to content

feat(migrations): Add new index to IncidentTrigger model #58467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ feedback: 0003_feedback_add_env
hybridcloud: 0005_add_missing_org_integration_scope
nodestore: 0002_nodestore_no_dictfield
replays: 0003_add_size_to_recording_segment
sentry: 0577_drop_latest_incident_index
sentry: 0578_add_index_on_incident_trigger_alert_ratelimit
social_auth: 0002_default_auto_field
1 change: 1 addition & 0 deletions src/sentry/incidents/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@ class Meta:
app_label = "sentry"
db_table = "sentry_incidenttrigger"
unique_together = (("incident", "alert_rule_trigger"),)
index_together = (("alert_rule_trigger", "incident_id"),)


class AlertRuleTriggerManager(BaseManager):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Generated by Django 3.2.20 on 2023-10-19 19:41

from django.db import migrations

from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production. For
# the most part, this should only be used for operations where it's safe to run the migration
# after your code has deployed. So this should not be used for most operations that alter the
# schema of a table.
# Here are some things that make sense to mark as dangerous:
# - Large data migrations. Typically we want these to be run manually by ops so that they can
# be monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# have ops run this and not block the deploy. Note that while adding an index is a schema
# change, it's completely safe to run the operation after the code has deployed.
is_dangerous = True

dependencies = [
("sentry", "0577_drop_latest_incident_index"),
]

operations = [
migrations.AlterIndexTogether(
name="incidenttrigger",
index_together={("alert_rule_trigger", "incident_id")},
),
]