Skip to content

chore(replay): Cleanup DOM Tab test, before we remove the tab itself #58486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

chore(replay): Cleanup DOM Tab test, before we remove the tab itself #58486

merged 1 commit into from
Oct 19, 2023

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Oct 19, 2023 •
edited
Loading

The DOM tab is going away in #58102, so we can remove the test for it.

@ryan953 ryan953 mentioned this pull request Oct 19, 2023
Merged
@ryan953 ryan953 requested a review from a team October 19, 2023 21:50
michellewzhang
michellewzhang approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip my test🥲

@ryan953 ryan953 enabled auto-merge (squash) October 19, 2023 21:51
@ryan953 ryan953 merged commit 3047b80 into master Oct 19, 2023
@ryan953 ryan953 deleted the ryan953/replay-cleanup-dom-tab-test branch October 19, 2023 22:35
ryan953 added a commit that referenced this pull request Oct 20, 2023
@ryan953
feat(replay): Load and render html of clicked dom elements in the Rep…
ac100a6 
…lay Details > Breadcrumbs tab (#58102)

This hides the DOM Tab, and instead shows HTML for click events in the
Breadcrumbs tab:
<img width="585" alt="SCR-20231013-ktum"
src="https://github.com/getsentry/sentry/assets/187460/53463d35-29e4-4017-9e29-4bd00192f89d">


Depends on #58092
Depends on #57942
Depends on #58486

Related to getsentry/team-replay#139
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michellewzhang michellewzhang michellewzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan953 @michellewzhang