Minor fixes #6
Merged
Minor fixes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BYK
added a commit
that referenced
this pull request
May 26, 2020
# This is the 1st commit message: build(docker): Split builder image out for better caching This is an experimental new approach which creates a separate builder image, that is highly cacheable (and allows caching for yarn install step) to generate the Python wheel. It should save us multiple minutes by leveraging our builds' incremental nature much better. # This is the commit message #2: remove redundant op, trigger subsequent build # This is the commit message #3: add SOURCE_COMMIT env to builder run # This is the commit message #4: oops # This is the commit message #5: add revision and license labels to builder # This is the commit message #6: use kaniko 0.22 as it should fix the weird failures # This is the commit message #7: Simpler and stronger .dockerignore
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey David,
I met you today at DjangoCon. Just pushed up a couple small patches, including an improvement to the README as SENTRY_KEY was not mentioned. It's kinda hard to set up multi-server without it :)
Keep up the good work.
Cheers,
Bryan