Skip to content

ref(badges): Move a bunch of badge* components into one folder #68843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 12, 2024

Moved a bunch of things named Badge* and tags.tsx into a happy folder together. A lot of them render about the same, so I'm thinking there's loads of duplicate code all over the place.

Lots of teams got tagged because imports got auto fixed for me, so i grouped up all the moves together into the one PR

Also, I added some stories for AlertBadge which turned out surprising:
SCR-20240412-noza

@ryan953 ryan953 requested review from a team as code owners April 12, 2024 22:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 12, 2024
Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, most of this is updating imports from all the files that use the various badge/ components. the added stories look good, and looks like all the components used on getsentry have also been accounted for

@ryan953 ryan953 merged commit 7fd84e7 into master Apr 15, 2024
42 checks passed
@ryan953 ryan953 deleted the ryan953/badges branch April 15, 2024 19:02
ryan953 added a commit that referenced this pull request Apr 16, 2024
…/badges/* (#68923)

In #68843 we moved a bunch of files around, and then
getsentry/getsentry#13646 needed to follow suit.
This cleans up the leftover stubs which we needed so build don't break
along the way.

Follows: #68843
Depends on getsentry/getsentry#13646
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants