Skip to content

chore: Register flag that consolidates all span-first UI #68911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shruthilayaj
Copy link
Member

Create an options backed flag for all starfish UI so we can enable them

@shruthilayaj shruthilayaj requested a review from a team April 15, 2024 17:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.71%. Comparing base (5b88c7e) to head (d71be76).
Report is 18 commits behind head on master.

❗ Current head d71be76 differs from pull request most recent head 9b24574. Consider uploading reports for the commit 9b24574 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #68911       +/-   ##
===========================================
+ Coverage   68.94%   79.71%   +10.76%     
===========================================
  Files        6422     6424        +2     
  Lines      284528   284737      +209     
  Branches    49021    49051       +30     
===========================================
+ Hits       196175   226981    +30806     
+ Misses      87948    57357    -30591     
+ Partials      405      399        -6     
Files Coverage Δ
src/sentry/conf/server.py 89.22% <ø> (ø)
src/sentry/features/temporary.py 100.00% <100.00%> (ø)
src/sentry/options/defaults.py 100.00% <100.00%> (ø)

... and 1400 files with indirect coverage changes

@shruthilayaj shruthilayaj enabled auto-merge (squash) April 15, 2024 18:47
@shruthilayaj shruthilayaj merged commit 82af73b into master Apr 15, 2024
48 checks passed
@shruthilayaj shruthilayaj deleted the shruthi/feat/register-an-options-backed-starfish-ui-feature-flag branch April 15, 2024 18:59
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants