ref(ui): Consolidate TeamBadge #68927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
reviewed
Apr 15, 2024
Comment on lines
+18
to
+21
| const {teams} = useLegacyStore(TeamStore); | ||
|
|
||
| // Get the most up-to-date team from the store | ||
| const resolvedTeam = teams.find(t => t.id === team.id) ?? team; |
There was a problem hiding this comment.
if teams is of type Team there's no point in all this since we have team: Team passed in
There was a problem hiding this comment.
yeah idk, I didn't want to touch this part
ryan953
approved these changes
Apr 15, 2024
This had an extraneous second component for some reason
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-ui-consolidate-teambadge
branch
from
44ef437 to
1b2e62e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had an extraneous second component for some reason