feat(crons): Add ability dispatch clock ticks to kafka #69896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
11 tasks
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-add-ability-dispatch-clock-ticks-to-kafka
branch
from
abbc932 to
ef73a24
Compare
wedamija
approved these changes
Apr 29, 2024
| # monitors-clock-pulse topic | ||
| pass | ||
| if settings.SENTRY_EVENTSTREAM != "sentry.eventstream.kafka.KafkaEventStream": | ||
| # XXX(epurkhiser): Unclear what we want to do if we're not using kafka |
There was a problem hiding this comment.
Just fire the tasks directly probably, it's only for dev
There was a problem hiding this comment.
Yeah I'll keep the logic separate to handle that 👍
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-add-ability-dispatch-clock-ticks-to-kafka
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.