Skip to content

feat(metrics): Default custom metric + dismiss empty state #70936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2024

Conversation

matejminar
Copy link
Member

@matejminar matejminar commented May 15, 2024

Instead of always showing transaction.duration, we now default to a custom metric.
Fixed the logic for showing empty state + add ability to dismiss it if you have performance metrics.

CleanShot.2024-05-15.at.15.22.44.mp4

Closes #69945
Closes #70209

@matejminar matejminar requested a review from a team as a code owner May 15, 2024 13:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 15, 2024
Copy link
Member

@obostjancic obostjancic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@matejminar matejminar merged commit c26e3dc into master May 15, 2024
41 of 42 checks passed
@matejminar matejminar deleted the feat/default-metric-dismiss-empty-state branch May 15, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty state (dimissable) Select the default item
2 participants