fix(relocation): Clean up relocation serializer #71930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of a series of changes to fix [SENTRY-38N6](https://sentry.sentry.io/issues/5282819613/). This is change 2 of 4: 1. Add new API to client in getsentry 2. Add new API to server in sentry <- THIS CHANGE 3. Remove old API from client in getsentry 4. Remove old API from server in sentry. This change extends the serializer to support both the new style of nested `creator`/`owner` objects, and the old, deprecated style. Fixes [SENTRY-38N6](https://sentry.sentry.io/issues/5282819613/).
github-actions
bot
added
the
Scope: Backend
hubertdeng123
approved these changes
Jun 3, 2024
azaslavsky
added a commit
that referenced
this pull request
Jun 5, 2024
This is part of a series of changes to fix [SENTRY-38N6](https://sentry.sentry.io/issues/5282819613/). This is change 4 of 4: [1](https://github.com/getsentry/getsentry/pull/14166). Add a new API to client in getsentry [2](#71930). Add new API to server in sentry [3](https://github.com/getsentry/getsentry/pull/14169). Remove old API, and only use new one, in getsentry 4. Remove old API from server in sentry <- THIS CHANGE Now that all clients that rely on this serializer only use new fields, we can go ahead and remove the old, flattened versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of changes to fix
SENTRY-38N6. This is change 2 of 4:
1. Add new API to client in getsentry
2. Add new API to server in sentry <- THIS CHANGE
3. Remove old API, and only use new one, in getsentry
4. Remove old API from server in sentry
This change extends the serializer to support both the new style of nested
creator/ownerobjects, and the old, deprecated style.Fixes SENTRY-38N6.