Skip to content

ref: remove wrapping RawEvent payload with CanonicalKeyView #72010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

asottile-sentry
Copy link
Member

it is a noop and I'm deleting the Canonical* data types since they are doing nothing

@asottile-sentry asottile-sentry requested review from jan-auer and a team June 4, 2024 15:35
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (32e77c7) to head (398d176).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72010       +/-   ##
===========================================
+ Coverage   56.90%   77.93%   +21.03%     
===========================================
  Files        6562     6570        +8     
  Lines      292219   292504      +285     
  Branches    50460    50508       +48     
===========================================
+ Hits       166285   227964    +61679     
+ Misses     121192    58295    -62897     
- Partials     4742     6245     +1503     
Files Coverage Δ
src/sentry/models/rawevent.py 94.44% <100.00%> (-0.30%) ⬇️

... and 1970 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit f26a1e0 into master Jun 4, 2024
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-raw-event-no-canonical branch June 4, 2024 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants