feat(self-hosted): Errors only self-hosted sidebar #72012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 134 bytes ⬆️
|
|
@gggritso I've noticed you've recently been working on sidebar changes, and wanted to loop you in as I've improved some of the test coverage here. |
azaslavsky
approved these changes
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72012 +/- ##
=======================================
Coverage 77.91% 77.91%
=======================================
Files 6573 6573
Lines 292701 292702 +1
Branches 50523 50523
=======================================
+ Hits 228053 228059 +6
+ Misses 58401 58396 -5
Partials 6247 6247
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
gggritso
added a commit
that referenced
this pull request
Jun 5, 2024
Follow-up to #72012. Updates the tests a bit, moves things around, and expands test coverage. - Move link set tests together - Simplify `ConfigStore` init - init in `beforeEach` - remove `act` - Update spec structure 1. Set up all possible sidebar feature flags 2. Await `Broadcast` mount 3. Fetch elements by role, not by ID 4. Check element by accessible title, not by ID
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 3 of #71948. The PR that originally introduced sidebar changes was reverted, causing frontend tests that were introduced here to fail.