-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(insights): show update SDK banner cache module #72015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72015 +/- ##
==========================================
- Coverage 77.94% 77.91% -0.03%
==========================================
Files 6571 6572 +1
Lines 292615 292719 +104
Branches 50523 50532 +9
==========================================
- Hits 228066 228065 -1
- Misses 58304 58410 +106
+ Partials 6245 6244 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd recommend some test coverage for this too since there's a bit of branching logic and we do slightly finicky things like a conditional on an exact error message |
If the cache hit miss rate chart aren't showing data, this likely means the customer is on an outdated SDK or they aren't sending

cache.hit
, so we display a message accordinglyThe message is not displayed if it is in an onboarding state