Skip to content

fix(traceview): Allow raw text on additional data when set #72038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

leeandher
Copy link
Member

Cards would previously force structured data which prevented this toggle from doing anything. This fixes that issue in the trace drawer.

Screen.Recording.2024-06-04.at.3.05.58.PM.mov

@leeandher leeandher requested review from a team as code owners June 4, 2024 19:08
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 4, 2024
@leeandher leeandher requested a review from Abdkhan14 June 4, 2024 19:08
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (27a2f5e) to head (365ceb9).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72038   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files        6573     6573           
  Lines      292707   292710    +3     
  Branches    50523    50527    +4     
=======================================
+ Hits       228059   228065    +6     
+ Misses      58401    58398    -3     
  Partials     6247     6247           
Files Coverage Δ
...tic/app/components/events/contexts/contextCard.tsx 75.00% <ø> (ø)
...mponents/events/highlights/editHighlightsModal.tsx 98.57% <ø> (ø)
...nce/newTraceDetails/traceDrawer/details/styles.tsx 51.93% <100.00%> (ø)
...er/details/transaction/sections/additionalData.tsx 23.52% <ø> (ø)
static/app/components/keyValueData/card.tsx 84.74% <0.00%> (-1.70%) ⬇️

... and 7 files with indirect coverage changes

@leeandher leeandher merged commit 28e500e into master Jun 4, 2024
41 of 42 checks passed
@leeandher leeandher deleted the leander/ref-details branch June 4, 2024 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants