Skip to content

feat(issues): Add front end for resolve in upcoming release #72619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

roggenkemper
Copy link
Member

this pr makes the front end changes to support resolve in upcoming release. backend changes in #70990. the changes made include adding an option to the Resolve button on issue details (hidden behind a feature flag), adding a subtitle to the resolve dropdown to clarify behavior, and updating the resolution box to support this form of resolution. the group activities item shouldn't need any updates as it mirrors the behavior as "resolve in next release"

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (b6e8016) to head (ed00843).
Report is 214 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72619      +/-   ##
==========================================
- Coverage   78.04%   78.02%   -0.03%     
==========================================
  Files        6596     6601       +5     
  Lines      293895   294126     +231     
  Branches    50700    50736      +36     
==========================================
+ Hits       229379   229485     +106     
- Misses      58256    58309      +53     
- Partials     6260     6332      +72     
Files Coverage Δ
static/app/types/group.tsx 73.68% <ø> (ø)
static/app/components/resolutionBox.tsx 91.66% <50.00%> (-3.79%) ⬇️
static/app/components/actions/resolve.tsx 64.86% <16.66%> (-4.26%) ⬇️

... and 267 files with indirect coverage changes

@roggenkemper roggenkemper marked this pull request as ready for review June 12, 2024 23:47
@roggenkemper roggenkemper requested a review from a team June 12, 2024 23:48
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to add a test, not sure how well tested this component is

@roggenkemper roggenkemper merged commit 459eba4 into master Jun 18, 2024
41 of 42 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/resolveupcomingfe branch June 18, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants