-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(trace) account for head or tail end of icons #72884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72884 +/- ##
==========================================
- Coverage 78.04% 78.03% -0.02%
==========================================
Files 6601 6602 +1
Lines 294316 294338 +22
Branches 50753 50749 -4
==========================================
- Hits 229708 229691 -17
+ Misses 58368 58317 -51
- Partials 6240 6330 +90
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a mix of snake case and camel case here that you may want to clean up at some point.
static/app/views/performance/newTraceDetails/traceRenderers/virtualizedViewManager.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceRenderers/virtualizedViewManager.tsx
Outdated
Show resolved
Hide resolved
…rtualizedViewManager.tsx Co-authored-by: Tony Xiao <[email protected]>
Span bars sometimes have icons at the head or tail end, which means they can overlap with the duration bars and cause visual issues. This PR computes the span bar space according to the min and max timestamps so that the duration labels no longer overlap.
Before:
CleanShot.2024-06-17.at.16.16.01.mp4
After:
CleanShot.2024-06-17.at.16.16.16.mp4