Skip to content

fix(trace) account for head or tail end of icons #72884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 17, 2024

Span bars sometimes have icons at the head or tail end, which means they can overlap with the duration bars and cause visual issues. This PR computes the span bar space according to the min and max timestamps so that the duration labels no longer overlap.

Before:

CleanShot.2024-06-17.at.16.16.01.mp4

After:

CleanShot.2024-06-17.at.16.16.16.mp4

@JonasBa JonasBa requested a review from Zylphrex June 17, 2024 20:19
@JonasBa JonasBa requested a review from a team as a code owner June 17, 2024 20:19
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 43.24324% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (312d1cb) to head (121729c).
Report is 68 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72884      +/-   ##
==========================================
- Coverage   78.04%   78.03%   -0.02%     
==========================================
  Files        6601     6602       +1     
  Lines      294316   294338      +22     
  Branches    50753    50749       -4     
==========================================
- Hits       229708   229691      -17     
+ Misses      58368    58317      -51     
- Partials     6240     6330      +90     
Files Coverage Δ
...ic/app/views/performance/newTraceDetails/trace.tsx 58.50% <100.00%> (+0.32%) ⬆️
...formance/newTraceDetails/traceModels/traceTree.tsx 71.04% <0.00%> (-0.15%) ⬇️
...eDetails/traceRenderers/virtualizedViewManager.tsx 45.70% <40.62%> (-0.29%) ⬇️

... and 158 files with indirect coverage changes

Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mix of snake case and camel case here that you may want to clean up at some point.

@JonasBa JonasBa merged commit 7b264ef into master Jun 18, 2024
41 of 42 checks passed
@JonasBa JonasBa deleted the jb/trace/icon-space branch June 18, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants