ref: fix types for integrations tasks

src/sentry/tasks/integrations/github/utils.py

@@ -16,7 +16,7 @@
 @dataclass
 class PullRequestIssue:
     title: str
-    subtitle: str
+    subtitle: str | None
     url: str
     affected_users: int | None = None
     event_count: int | None = None
@@ -38,7 +38,7 @@ class GithubAPIErrorType(Enum):
 def create_or_update_comment(
     client: GitHubAppsClient,
     repo: Repository,
-    pr_key: int,
+    pr_key: str,
     comment_body: str,
     pullrequest_id: int,
     issue_list: list[int],

src/sentry/tasks/integrations/sync_metadata.py

@@ -13,9 +13,13 @@
 )
 @retry(on=(IntegrationError,), exclude=(Integration.DoesNotExist,))
 def sync_metadata(integration_id: int) -> None:
+    from sentry.integrations.jira.integration import JiraIntegration
+    from sentry.integrations.jira_server.integration import JiraServerIntegration
+
     integration = Integration.objects.get(id=integration_id)
     org_install = integration.organizationintegration_set.first()
     if not org_install:
         return
     installation = integration.get_installation(org_install.organization_id)
+    assert isinstance(installation, (JiraIntegration, JiraServerIntegration)), installation
     installation.sync_metadata()

src/sentry/tasks/integrations/vsts/subscription_check.py

@@ -19,8 +19,11 @@
 )
 @retry(exclude=(ApiError, ApiUnauthorized, Integration.DoesNotExist))
 def vsts_subscription_check(integration_id: int, organization_id: int) -> None:
+    from sentry.integrations.vsts.integration import VstsIntegration
+
     integration = Integration.objects.get(id=integration_id)
     installation = integration.get_installation(organization_id=organization_id)
+    assert isinstance(installation, VstsIntegration), installation
     try:
         client = installation.get_client(base_url=installation.instance)
     except ObjectDoesNotExist:
@@ -45,7 +48,7 @@ def vsts_subscription_check(integration_id: int, organization_id: int) -> None:
     if not subscription or subscription["status"] == "disabledBySystem":
         # Update subscription does not work for disabled subscriptions
         # We instead will try to delete and then create a new one.
-        if subscription:
+        if subscription and subscription_id is not None:
             try:
                 client.delete_subscription(subscription_id=subscription_id)
             except ApiError as e: