Skip to content

fix(insights): updated empty-state copy for caches / queues #72905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 18, 2024

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jun 17, 2024

Better describe the benefits of using the cache / queue insights modules:

Screenshot 2024-06-18 at 2 44 34 PM Screenshot 2024-06-18 at 2 44 27 PM

@bcoe bcoe requested a review from a team as a code owner June 17, 2024 21:52
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Bundle Report

Changes will decrease total bundle size by 20.06kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 27.29MB 20.06kB ⬇️

Copy link
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a lot more descriptive

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (9ebd80d) to head (bb0437e).

Current head bb0437e differs from pull request most recent head 66c0382

Please upload reports for the commit 66c0382 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72905       +/-   ##
===========================================
+ Coverage   53.77%   78.05%   +24.28%     
===========================================
  Files        2891     6606     +3715     
  Lines      179964   294460   +114496     
  Branches    32175    50763    +18588     
===========================================
+ Hits        96767   229832   +133065     
+ Misses      78827    58296    -20531     
- Partials     4370     6332     +1962     
Files Coverage Δ
static/app/views/performance/cache/settings.ts 100.00% <ø> (ø)
static/app/views/performance/queues/settings.ts 100.00% <ø> (ø)

... and 5695 files with indirect coverage changes

@bcoe bcoe force-pushed the empty-state-blurbs-cache-queue branch from 4037f6d to def5819 Compare June 18, 2024 18:41
@bcoe bcoe merged commit 131d1d8 into master Jun 18, 2024
41 checks passed
@bcoe bcoe deleted the empty-state-blurbs-cache-queue branch June 18, 2024 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants